USHIFT-5531: Auto-rebase procedure with flannel and kube-proxy image update #4726
Conversation
|
@praveenkumar: This pull request references USHIFT-5531 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
praveenkumar
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: praveenkumar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
praveenkumar
force-pushed
the
issue_5531
branch
2 times, most recently
from
a4a83ab to
4837374
Compare
praveenkumar
force-pushed
the
issue_5531
branch
from
4837374 to
124b1ca
Compare
praveenkumar
force-pushed
the
issue_5531
branch
from
124b1ca to
5d95c73
Compare
|
/test ? |
|
@ggiguash: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ggiguash Do we need any other test than default running ones? |
Yes I was checking that and looks like still ignored so may be https://github.com/openshift/microshift/blob/main/scripts/auto-rebase/assets.yaml#L268-L296 also need to updated? |
|
@praveenkumar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| @@ -102,6 +102,23 @@ def run_rebase_ai_model_serving_sh(release): | |||
| return RebaseScriptResult(success=result.returncode == 0, output=result.stdout) | |||
|
|
|||
|
|
|||
| def run_rebase_flannel(): | |||
There was a problem hiding this comment.
Should this function be executed?
I recall that newest flannel requires a kernel module, should we even proceed with this PR?
| @@ -1118,6 +1119,44 @@ EOF | |||
| done # for goarch | |||
| } | |||
|
|
|||
| update_kubeproxy_images() { | |||
There was a problem hiding this comment.
Do you know what's the difference between kube-proxy and kube-rbac-proxy? Can they be used interchangeably?
Which issue(s) this PR addresses:
Closes #